fix(nl): fix potential missing NUL terminator #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling with `-DCMAKE_BUILD_TYPE=Release`, we get a `-Wstringop-truncation` warning. This is because when strncpy exits early because the input string is too long, it **DOES NOT** copy a nul terminator. Instead, we need to manually setup a nul terminator ourselves.
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 49.26% 50.20% +0.94%
==========================================
Files 116 116
Lines 18629 19249 +620
==========================================
+ Hits 9177 9664 +487
- Misses 9452 9585 +133
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling with
-DCMAKE_BUILD_TYPE=Release, we get a-Wstringop-truncationwarning.This is because when
strncpyexits early because the input string is too long, it DOES NOT copy a NUL terminator. Instead, we need to manually setup a NUL terminator ourselves.Side-note, I've been trying to use NULL to denote
NULL(aka ptr type) and NUL/␀ to denote'\0'(aka char/byte type). That seems to be the convention for C programmers.