-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Google profile information #276
Conversation
It is necessary to get user data such as Save and photoURL
Fixed empty space using '+' character to add scopes
A few things:
https://github.com/nraboy/ng-cordova-oauth#contribution-rules I appreciate the contributions though :-) |
I can't find this tag in the documentation, only debugging the firebase authentication like the following post https://groups.google.com/forum/#!topic/firebase-talk/35lFiZzzUII and testing with my Android device with GapDebug |
And you're sure it does not force extra permissions? Make add your changes to the development branch and make a new PR and I'll merge it. Best, |
I think this could be an option to not force all users of the lib to include that on their authentication request, what do you think @nraboy and @jdnichollsc ? |
@nraboy @matheusrocha89 Sorry for the delay, check the pull request #304 Best regards, Nicholls |
I am open to either as long as it doesn't force extra permissions. Would you like it to default or would you like it to be an option? |
Default option is good for me 👍 |
It is necessary to get user data such as displayName and photoURL from Google