Ignore unrelated field attributes

[siler]

Currently all attributes on fields are parsed by derive-new. This change updates the attribute parsing logic to ignore any attribute that aren't specifically for derive-new. For example, previously:

#[derive(new)]
pub struct All {
    #[allow(missing_docs)]
    pub x: i32
}

Would result in the following error:

error: proc-macro derive panicked
--> tests\test.rs:289:10
|
289 | #[derive(new, PartialEq, Debug)]
| ^^^
|
= help: message: Invalid #[new] attribute: #[new(missing_docs)]

The revision of compiletest was updated to allow all tests to build on stable. It might be a good idea to configure the CI to use the minimum supported version of Rust to execute tests.

Additionally, I was having issues building tests due to the workspace configuration and syn::Generics. I didn't look into it much, but removed the workspace configuration so it wouldn't affect others.

[nrc]

Looks good, just curious about the Cargo.toml change

[nrc]

Why is this change necessary?

[siler]

When the workspace is set up I see the following:

derive-new\testcrate> cargo test
   Compiling libc v0.2.39
   Compiling kernel32-sys v0.2.2
   Compiling derive-new v0.5.3
   Compiling serde_derive v1.0.37
   Compiling term v0.4.6
error[E0599]: no method named `make_where_clause` found for type `syn::Generics` in the current scope
  --> github.com-1ecc6299db9ec823\serde_derive-1.0.37\src\bound.rs:47:14
   |
47 |     generics.make_where_clause()
   |              ^^^^^^^^^^^^^^^^^

I looked into it a bit but didn't root cause it. Might not occur on a *nix box if the build failed in term.

[nrc]

This is an error in serde_derive, and it would be weird to see that only on some platforms. I'm on Mac OS and build without error. Maybe it is due to how you are running the tests? I run cargo test --all from the root directory, rather than anything in testcrate

[siler]

Yeah, that seems unlikely. I see the same errors when I execute tests that way.

Edit: happens with both stable and nightly msvc.

[nrc]

ping @dtolnay any idea what might be going on with this Serde build error?

[dtolnay]

No idea but it seems like the sort of thing that cargo update (or not having a lockfile checked in) would fix.

[siler]

Looks like you're right, added it back.

[siler]

Well that is amusing.

[nrc]

Thanks!

[nrc]

Published 0.5.4