Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update syn, quote and proc-macro2 #37

Merged
merged 1 commit into from
May 23, 2018

Conversation

hcpl
Copy link
Contributor

@hcpl hcpl commented May 21, 2018

No description provided.

@nrc
Copy link
Owner

nrc commented May 22, 2018

Looks like nightly tests are failing. Do you know what is happening there?

@hcpl
Copy link
Contributor Author

hcpl commented May 23, 2018

This is because each of these commands:

- rust: nightly
script:
- cargo test
- cargo test --manifest-path testcrate/Cargo.toml
creates its own target/debug/deps/libderive_new-${hash}.so with a unique hash which confuses compiletest_rs since it doesn't know how to tell which one is the right one.

@nrc nrc merged commit 4d87ffe into nrc:master May 23, 2018
@nrc
Copy link
Owner

nrc commented May 23, 2018

Thanks for the PR!

@hcpl
Copy link
Contributor Author

hcpl commented May 23, 2018

I just tried the script below which resolved this problem for me:

#!/bin/sh
cargo +nightly test
rm target/debug/deps/libderive_new-*.so
cargo +nightly test --manifest-path testcrate/Cargo.toml

I'll try to adapt this for .travis.yml in the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants