Fix Travis CI nightly build #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because both regular test and `testcrate` test create their own
`target/debug/deps/libderive_new-${hash}.so` with a unique hash,
`compiletest_rs` gets confused since it doesn't know how to tell which
one is the right one.
|
Nice, thanks!
Sure, although I'm not sure if it will actually work since I think we use some of the newer proc macro stuff as well as just custom derive, in which case I guess we should update the README. |
|
I did check with my local 1.15 and all test pass, so I'll prepare yet another PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was easier than I thought: https://travis-ci.org/hcpl/derive-new/builds/382464446.
Also, would you mind if I added a Rust 1.15 build? The README makes it sound like
derive-newshould work in every Rust version that has stable#[derive]which means every version since 1.15.