replace rate limiter by retryablehttp #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
desec lower the limit for rrsets to 2/s: https://github.com/desec-io/desec-stack/blob/4df53eb8e63e6d68d6d7a2b3390c293fe13822e3/api/api/settings.py#L115
I think it is better to use the Retry-After http header for this case when a 429 error occurs, since the limits can be updated at any time.
To avoid reinventing the wheel, I used https://github.com/hashicorp/go-retryablehttp.
I will update this projects https://github.com/go-acme/lego and https://github.com/Valodim/terraform-provider-desec because i have the problem in both.
Fixes #2
Fixes Valodim/terraform-provider-desec#5