ENH: Add group transformers #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richford
added
enhancement
…t or remove groups based on group name
|
@arokem, ready to review. |
3 tasks
arokem
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #50
WIP until I add all of the transformers.
Also, these transformers currently take indices of groups to extract/remove. We should optionally allow the user to pass a feature name to select or remove. We could then check the feature name against elements of the feature column names (provided as another kwarg or taken from
DataFrame.columnsifXis a dataframe). That way, the user wouldn't have to remember which group index corresponds to the CST, for example.