Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kibana CSS changed on plugin install #47

Closed
HungryHumps opened this issue Mar 24, 2017 · 7 comments
Closed

Kibana CSS changed on plugin install #47

HungryHumps opened this issue Mar 24, 2017 · 7 comments

Comments

@HungryHumps
Copy link

After installing the plugin, the buttons and banners will change their rendered output from default.
Noticeable on the visualisations buttons, as well as error banners.

@nreese
Copy link
Owner

nreese commented Mar 24, 2017

Can you provide some screen shots. I am not sure what you are talking about

@iamyourexpert
Copy link

I think if you change the dashboard to dark background, the viz shows a white bar.

@HungryHumps
Copy link
Author

HungryHumps commented Mar 31, 2017 via email

@nreese
Copy link
Owner

nreese commented Apr 3, 2017

Looks like the screen shots did not make it into the issue. Can you try reposting them?

@szydan
Copy link

szydan commented Apr 28, 2017

The issue is that your less file is declaring some classes on root level e.g:
https://github.com/nreese/enhanced_tilemap/blob/master/public/vis.less#L37

To avoid messing other components styles
you should make the css more specific
Classes which are used in main plugin viev should all be wrapped in etm-vis class like

 .etm-vis {
    .btn-input:hover {
      color: #2D2D2D;
    }
    ... HERE REST OF THE CLASSES 

}

The same should be done for options screen
https://github.com/nreese/enhanced_tilemap/blob/master/public/options.html

by wrapping the whole view in a single div with a class

<div class="etm-vis-options">
</div>

and then again in less wrap all classes used in this view like

 .etm-vis-options {
    ... HERE ALL CLASSES USED IN OPTIONS VIEW
}

In this way your css will not mess up with other plugins and kibana

@mehmetfurkanaydin
Copy link

Enhanced Tilemap plugin uses bootstrap-theme.css and this file changes default Kibana styles.

This was referenced May 4, 2017
@nreese
Copy link
Owner

nreese commented Oct 20, 2017

Closing. New releases (https://github.com/nreese/enhanced_tilemap/releases/tag/v2017-09-23 and onward) remove bootstrap CSS from plugin. The bootstrap CSS was stomping on kibana's CSS

@nreese nreese closed this as completed Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants