Add HAL for nRF51 series #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once ready, nrf-rs/nrf51#9 will need to be merged and a new version published so that this PR can point to version 0.9.0 of |
fmckeogh
force-pushed
the
master
branch
3 times, most recently
from
c22c623
to
82108d9
Compare
|
Ok, now #113 really needs to be done :) |
fmckeogh
force-pushed
the
master
branch
2 times, most recently
from
82108d9
to
7316445
Compare
* Add clocks, gpio, rng, temp, time, timer, uart and uicr modules to HAL
jonas-schievink
approved these changes
Apr 20, 2020
|
Okay to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the Matrix room, my current strategy will be to favour keeping the APIs consistent over exact/correct naming and an increase in code complexity due to many feature gates.
For example, the nRF51 does not have EasyDMA for UART, and so the peripheral is called
UARTbut has been feature gated inside the nRF52UARTEmodule. I think more discussion might be needed, but IMHO the benefit to users who want to be able to write agnostic code for any nRF5x device is greater than the confusion that will arise from the missing methods and inconsistent naming.EDIT: Spoke too soon, there were many difference and so are now separate modules for the nRF51 versions of peripherals where needed. The API's have still been kept as similar as possible however.
TODO