mpsl: fem: increase initialization priority #10120
Conversation
Front-End Module initialization is a dependency of HCI driver initialization. Increase its priority so that there's a clear hierarchy between them. Signed-off-by: Jędrzej Ciupis <jedrzej.ciupis@nordicsemi.no>
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
| @@ -293,7 +293,7 @@ static int mpsl_fem_init(const struct device *dev) | |||
| return fem_nrf21540_gpio_configure(); | |||
| } | |||
|
|
|||
| SYS_INIT(mpsl_fem_init, POST_KERNEL, CONFIG_KERNEL_INIT_PRIORITY_DEVICE); | |||
| SYS_INIT(mpsl_fem_init, POST_KERNEL, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT); | |||
There was a problem hiding this comment.
I'm afraid if this is done this way at some point we will forget, why the change was introduced. Is there any way to make this initialization priority relative to SDC initialization priority?
There was a problem hiding this comment.
One way that comes to my mind is that there could be a dedicated Kconfig option representing MPSL FEM initialization priority and another one representing HCI driver initialization priority. We could then give them correct default values and put a build assert to enforce the dependency. It feels to be a bit of an overkill though. What do you think? Do you have other ideas?
There was a problem hiding this comment.
This would be exactly the approach I think I would choose.
It's easier to track dependencies between initialization priorities if they have their own Kconfig entries. Signed-off-by: Jędrzej Ciupis <jedrzej.ciupis@nordicsemi.no>
The new Kconfig option is used for a build assert to enforce an explicit dependency on initialization priority of MPSL FEM. Signed-off-by: Jędrzej Ciupis <jedrzej.ciupis@nordicsemi.no>
|
I would really like you to update the commit message to describe what problem you are trying to solve |
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
|
Maybe #10143 does the same thing? |
|
Superseded by #10143 |
rugeGerritsen
added
the
doc-required
Front-End Module initialization is a dependency of HCI driver initialization. Increase its priority so that there's a clear hierarchy between them.
Signed-off-by: Jędrzej Ciupis jedrzej.ciupis@nordicsemi.no