applications: serial_lte_mondem: NCSIDB-138 Serial LTE Modem two feat… #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
junqingzou
force-pushed
the
pr_ncsidb_138
branch
from
edbc26c
to
a1b00a7
Compare
rlubos
reviewed
Jun 22, 2020
| @@ -19,6 +19,7 @@ LOG_MODULE_REGISTER(tcp_proxy, CONFIG_SLM_LOG_LEVEL); | |||
| #define THREAD_STACK_SIZE (KB(1) + NET_IPV4_MTU) | |||
| #define THREAD_PRIORITY K_LOWEST_APPLICATION_THREAD_PRIO | |||
| #define DATA_HEX_MAX_SIZE (2 * NET_IPV4_MTU) | |||
| #define data_buf_SIZE CONFIG_AT_CMD_RESPONSE_MAX_LEN/2 | |||
There was a problem hiding this comment.
Please use upper case for defines. Spaces around /.
| @@ -344,6 +350,33 @@ static int do_tcp_send(const u8_t *data, int datalen) | |||
| } | |||
| } | |||
|
|
|||
| static int tcp_data_save(u8_t *data, u16_t length) | |||
| { | |||
| u16_t sz_avail; | |||
There was a problem hiding this comment.
Zephyr provides a ring buffer implementation, have you considered using it instead of implementing it on your own? Should be less error-prone:
https://github.com/zephyrproject-rtos/zephyr/blob/master/include/sys/ring_buffer.h#L346
From what I understand all we need is to declare a ring buffer and then call ring_buf_put()/ring_buf_get() when needed.
junqingzou
force-pushed
the
pr_ncsidb_138
branch
from
a1b00a7
to
cb77a98
Compare
…ures Customer engineering, new features added to SLM TCP Proxy Feature nrfconnect#1 is handled by new unsolicited notification of "#XTCPDATA", then client could fetch all data with "AT#XTCPRECV" command. If received data cannot be reserved inside SLM, an OVERRUN unsolicited notification is sent then data is dropped. Feature nrfconnect#2 is handled by returning socket handles. Also added an unsolicited notification when TCP Server close client connection due to connection time-out. Signed-off-by: Jun Qing Zou <jun.qing.zou@nordicsemi.no>
junqingzou
force-pushed
the
pr_ncsidb_138
branch
from
cb77a98
to
a89fb99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customer engineering, new features added to SLM TCP Proxy
Feature #1 is handled by new unsolicited notification of "#XTCPDATA",
then client could fetch all data with "AT#XTCPRECV" command. If
received data cannot be reserved inside SLM, an OVERRUN unsolicited
notification is sent then data is dropped.
Feature #2 is handled by returning socket handles. Also added an
unsolicited notification when TCP Server close client connection due to
connection time-out.
Signed-off-by: Jun Qing Zou jun.qing.zou@nordicsemi.no