Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme and make CI work #5

Merged
merged 12 commits into from
Oct 14, 2020
Merged

Add readme and make CI work #5

merged 12 commits into from
Oct 14, 2020

Conversation

doron-st
Copy link
Collaborator

@doron-st doron-st commented Oct 8, 2020

Add the readme to pypi
fix workflow typo which caused CI not to run
Fix failing tests
Fix workflows issue with logging ini file that wasn't availabe in CI server by creating another example module without logging solely for the ci

@doron-st doron-st requested a review from zozo123 October 8, 2020 08:39
Copy link
Contributor

@zozo123 zozo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doron-st
Copy link
Collaborator Author

Phewww.
I had to work around CI issue.
Couldn't get github workflows to use the correct logging config, and it kept failing on this.
I had to create a new module, without logging, just for the purpose of testing and CI.
It's not elegant at all, but it's the only way I could pass the CI.
If you have other ideas, let's try them

@doron-st doron-st changed the title Add readme Add readme and make CI work Oct 14, 2020
@doron-st doron-st merged commit 71a5eba into master Oct 14, 2020
@doron-st doron-st deleted the add_readme branch October 14, 2020 18:31
Copy link
Contributor

@zozo123 zozo123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.6, 3.7, 3.8]
python-version: [3.7]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 3.8?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants