Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid cast exception thrown by HalLinksSubclassPropertySetterAnalyzer #11

Merged
merged 4 commits into from
May 9, 2018
Merged

Fix invalid cast exception thrown by HalLinksSubclassPropertySetterAnalyzer #11

merged 4 commits into from
May 9, 2018

Conversation

olejace
Copy link

@olejace olejace commented May 8, 2018

image

HalLinksSubclassPropertySetterAnalyzer throws System.InvalidCastException while checking types for privates setters.

Moving the parent variable closer to scope and within the IsHalLinks()-check. Also using the superclass TypeDeclarationSyntax

@olejace olejace self-assigned this May 8, 2018
@olejace olejace requested a review from einarwh May 8, 2018 11:25
@olejace olejace merged commit 70c87de into master May 9, 2018
@olejace olejace deleted the FixInvalidCastException branch May 9, 2018 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@einarwh einarwh einarwh approved these changes

Assignees

@olejace olejace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olejace @einarwh