-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add onTake and onSetAsNext blueprint callbacks SOFIE-2897 SOFIE-2808 #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release51 #1117 +/- ##
=============================================
+ Coverage 57.74% 57.94% +0.20%
=============================================
Files 512 517 +5
Lines 82571 83159 +588
Branches 4307 4351 +44
=============================================
+ Hits 47679 48188 +509
- Misses 34841 34917 +76
- Partials 51 54 +3 ☔ View full report in Codecov by Sentry. |
jstarpl
added
the
Contribution from BBC
Contributions sponsored by BBC (bbc.co.uk)
label
Jan 12, 2024
pieceMetaDataFilter is now piecePrivateDataFilter
Julusian
changed the title
feat: add onTake and onSetAsNext blueprint callbacks
feat: add onTake and onSetAsNext blueprint callbacks SOFIE-2897 SOFIE-2808
Jan 15, 2024
Julusian
approved these changes
Jan 17, 2024
packages/job-worker/src/blueprints/context/services/PartAndPieceInstanceActionService.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Julian Waller <git@julusian.co.uk>
@Julusian the comments were addressed, and merge conflicts resolved |
jstarpl
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This pull request is posted on behalf of the BBC.
Type of Contribution
This is a:
Feature (addition to the Blueprints API)
Current Behavior
As described in the RFC #1013 and its subsequent comments, it is currently not possible to modify Parts and their Pieces while a Take is being performed or while a part is being set as Next.
New Behavior
Two new optional blueprint callbacks are added to the
ShowStyleBlueprintManifest
:onTake
- Called during a Take action. Allows for Part (Instances) modification or aborting the take.onSetAsNext
- Called when a part is set as Next, including right after a Take. Allows for Part (Instances) modification.Testing Instructions
Implement the
onTake
andonSetAsNext
callbacks inShowStyleBlueprintManifest
of the blueprints and verify that methods of the contexts passed to those callbacks are acting as documented.This feature shares some code with Adlib Actions. Since the logic behind
IActionExecutionContext
was refactored for reuse in this feature, Adlib Action execution needs to be tested for regressions as well.Other Information
Status