Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace jQuery with native API calls #86

Merged
31 commits merged into from
Jun 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 15, 2019

Note: these changes intentionally disregards support for Internet Explorer. Edge is still supported, as is newest versions of Chrome, Firefox and Safari.

@ghost ghost requested review from nytamin and jstarpl May 27, 2019 13:42
@ghost ghost self-assigned this May 27, 2019
Copy link
Member

@jstarpl jstarpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels generally OK, apart from the loose typing on the JQueryCoordinates replacement.

@ghost ghost marked this pull request as ready for review June 7, 2019 13:02
@ghost ghost changed the title WIP Replace jQuery with native API calls chore: Replace jQuery with native API calls Jun 7, 2019
@jstarpl
Copy link
Member

jstarpl commented Jun 10, 2019

Yup, everything seems to be OK here now.

@ghost ghost merged commit a35b80d into develop Jun 12, 2019
@ghost ghost deleted the feature/replace-jquery-with-native-api-calls branch June 12, 2019 11:55
@nytamin nytamin mentioned this pull request Jul 1, 2019
5 tasks
nytamin pushed a commit that referenced this pull request Mar 18, 2022
fix: Added filter support for TEXT_LABEL to panel-based dashboard_layouts.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants