-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace jQuery with native API calls #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
May 27, 2019
jstarpl
requested changes
Jun 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels generally OK, apart from the loose typing on the JQueryCoordinates replacement.
meteor/client/ui/SegmentTimeline/Renderers/CustomLayerItemRenderer.tsx
Outdated
Show resolved
Hide resolved
ghost
marked this pull request as ready for review
June 7, 2019 13:02
ghost
changed the title
WIP Replace jQuery with native API calls
chore: Replace jQuery with native API calls
Jun 7, 2019
Yup, everything seems to be OK here now. |
jstarpl
approved these changes
Jun 10, 2019
… with window.scrollY
ghost
deleted the
feature/replace-jquery-with-native-api-calls
branch
June 12, 2019 11:55
5 tasks
nytamin
pushed a commit
that referenced
this pull request
Mar 18, 2022
fix: Added filter support for TEXT_LABEL to panel-based dashboard_layouts.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: these changes intentionally disregards support for Internet Explorer. Edge is still supported, as is newest versions of Chrome, Firefox and Safari.