Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 response codes use 'active slot' instead of 'slotId' #12

Closed
sphlabs opened this issue Feb 15, 2021 · 6 comments · Fixed by #25
Closed

508 response codes use 'active slot' instead of 'slotId' #12

sphlabs opened this issue Feb 15, 2021 · 6 comments · Fixed by #25

Comments

@sphlabs
Copy link
Contributor

sphlabs commented Feb 15, 2021

  • I'm submitting a ...
    [X] bug report
    [ ] feature request
    [ ] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary
    If a slot change is initiated by the slot select command, the 508 response message that is returned uses the id active slot rather than slotId to identify the slot. Currently only slotId is being matched and passed up the chain.

The transport async handler needs to recognise active slot and pass it up as slotId

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)
@mint-dewit
Copy link
Contributor

Do you know if this is an issue in all firmware versions or did it change in one of the newer versions?

@sphlabs
Copy link
Contributor Author

sphlabs commented Feb 16, 2021 via email

@mint-dewit
Copy link
Contributor

I actually stumbled upon a device with API v1.3 earlier today and it had the same response so I don't think this is recent, when you pull a drive does it send a slot id instead or is that not even a transport info? (I only have remote access so can't pull drives myself)

I think I'll put in a fix for this while doing the v1.11 work

@sphlabs
Copy link
Contributor Author

sphlabs commented Feb 16, 2021 via email

@mint-dewit
Copy link
Contributor

Yes, that's also what I'm seeing and the 208 is probably what the initial implementation was based on, I just wondered if it was ever possible to get a 508 in combination with a slot id or if it is only active slot. Because in the first case I need to handle both cases but in the latter case I can just change the parameter name in the deserialization

@sphlabs
Copy link
Contributor Author

sphlabs commented Feb 16, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants