Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the available docker content to be more "publish friendly". I think it would be great if cpcache had an official dockerhub image.
I am moving to a new Ubuntu-based router and wanted to use cpcache dockerized. There were two reasons for me to start this work:
As I know nothing about elixir, I have taken heavy inspiration from your own AUR package. Here is a screenshot comparison of image size produced:
The proposed version is missing one more important step to consider it "cloud-ready" -> environment based configuration. I could have written a wrapper around the main
toml
config, but I figured that if you really wanted to go through this exercise properly, it would be much better to adjust the application itself to take its config via environment vars.Let me know what you think. I've been using my version a few days serving all my arch machines and it works like a charm.