Copydays #29
Merged
Copydays #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmaz
reviewed
Oct 13, 2023
| @@ -103,56 +112,38 @@ pimmi clusters --config-path my_pimmi_conf.yml dataset1 | |||
| ``` | |||
|
|
|||
| ## Test on the Copydays dataset | |||
| You can find the dataset explanations [here](https://lear.inrialpes.fr/~jegou/data.php#copydays). Unfortunately, the data files are not available anymore, you can get them from [web archive](http://web.archive.org/web/20181015092553if_/http://pascal.inrialpes.fr/data/holidays/). | |||
There was a problem hiding this comment.
The link is broken, please use https://web.archive.org/web/20170325224315/https://lear.inrialpes.fr/people/jegou/data.php#copydays
So the first paragraph should explain that everything is on web archive
README.md
Outdated
| │ └───75 | ||
| └───strong | ||
| └───jpegqual | ||
| └───copydays_strong | ||
| ``` | ||
|
|
||
| You can then play with the different parameters and evaluate the results. If you want to loop over several parameters to optimize your settings, you may have a look at eval_copydays.sh. |
There was a problem hiding this comment.
the README should mention that eval_copydays.sh and copydays_groundtruth.py are in the "script" folder in the github repo. So anyone who wishes to reproduce the results should clone the repo.
README.md
Outdated
| pimmi --sift-nfeatures 1000 --index-type IVF1024,Flat fill images/ my_index_folder | ||
| pimmi --query-sift-knn 1000 --query-dist-ratio-threshold 0.8 --index-type IVF1024,Flat query images my_index_folder -o result_query.csv | ||
| pimmi --index-type IVF1024,Flat --algo components clusters my_index_folder result_query.csv -o clusters.csv | ||
| python ../scripts/copydays_groundtruth.py images/ clusters.csv |
There was a problem hiding this comment.
why ../scripts instead of scripts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.