-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: yarn version detection #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Can you also patch the version in https://github.com/nrwl/ci/blob/main/README.md and https://github.com/nrwl/ci/blob/main/package.json to 0.11.1 so this fix is automatically accessible?
Done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment
Thanks again @rrooding! It's been released |
Because the Yarn version does not start with a
v
the first character should not be cut off. This is true for all major yarn versions:Because of this the action currently falls back to yarn berry and this means that if you use yarn 1.x, caching does not work:
I'm not sure how to write a test for this since the workflow works but only gives a warning in the last step.