fix: adapt chart for OpenShift #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minijus
commented
Apr 14, 2023
| runAsGroup: 10000 | ||
| fsGroup: 10000 | ||
| fsGroupChangePolicy: "OnRootMismatch" | ||
| {{- if .Values.fileServer.securityContext.enabled }} |
There was a problem hiding this comment.
Some OpenShift environments are not too happy about specific user IDs or groups. Thus, exposing configuration to disable this securityContext.
minijus
commented
Apr 14, 2023
There was a problem hiding this comment.
Adding quite common (from Bitnami charts) patterns for defining images, pullPolicy and resources.
minijus
commented
Apr 14, 2023
| digest: '' | ||
| pullPolicy: Always | ||
| resources: | ||
| limits: {} |
There was a problem hiding this comment.
Some OpenShift environments require limits to be specified. Thus, exposing them on configuration.
minijus
commented
Apr 14, 2023
| @@ -1,11 +1,94 @@ | |||
| image: | |||
There was a problem hiding this comment.
Technically removal of image.tag will be a breaking change for this update. If you are ok with this change, I will go and update remaining READMEs and examples.
minijus
force-pushed
the
adapt-for-openshift
branch
2 times, most recently
from
d665136
to
4ced1be
Compare
minijus
force-pushed
the
adapt-for-openshift
branch
from
4ced1be
to
80c1f8a
Compare
|
Rebased for messagequeue changes. |
rarmatei
approved these changes
Apr 20, 2023
|
Thank you @scritchley @rarmatei ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.