Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong query string parameter call results in same page of pipelines #43

Closed
eladhaim22 opened this issue Sep 18, 2022 · 1 comment · Fixed by #44
Closed

Wrong query string parameter call results in same page of pipelines #43

eladhaim22 opened this issue Sep 18, 2022 · 1 comment · Fixed by #44
Labels
bug Something isn't working

Comments

@eladhaim22
Copy link
Contributor

eladhaim22 commented Sep 18, 2022

Orb version: 1.6.0

What happened:

We noticed that in some cases the step fails due to a timeout error(10 min in our cases).
When inspecting the logs we noticed that the the set-sha commands seem to "hangs".

Expected behavior:

The set-sha command should alwayes results in FROM and TO commits.

Additional Information:

After some checks and debugging we identify that the error is a result of wrong api call.
The find successful script calls the pipeline api with "page" as a query param, but looking on circleci api here
it expects a "page-token" query param, so the pipeline list always return the same list and if the last successful pipeline is not on the first page the circleci step will hangs.

@eladhaim22 eladhaim22 added the bug Something isn't working label Sep 18, 2022
eladhaim22 pushed a commit to eladhaim22/nx-orb that referenced this issue Sep 18, 2022
Change page query param to page-token query param
Closes nrwl#43
@meeroslav
Copy link
Collaborator

Hm, good catch. This seems to have changed recently on their API but we did not follow it through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants