feat(nx-dev): remove emojis from heading ID

nrwl · Sep 15, 2023 · 62aa63f · 62aa63f
1 parent 6242c87
commit 62aa63f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 5 deletions.
diff --git a/nx-dev/feature-ai/src/lib/feed/feed-answer.tsx b/nx-dev/feature-ai/src/lib/feed/feed-answer.tsx
@@ -19,6 +19,7 @@ interface RehypeNode {
   children?: RehypeNode[];
   value?: string;
 }
+
 function openLinksInNewTab() {
   function walk(node: RehypeNode, callback: (node: RehypeNode) => void): void {
     callback(node);
@@ -30,7 +31,6 @@ function openLinksInNewTab() {
   return (tree: RehypeNode) => {
     walk(tree, (node) => {
       if (node.type === 'element' && node.tagName === 'a') {
-        console.log(node);
         const props = node.properties ?? {};
         const href = props?.['href'] as string;
         props.target = '_blank';

diff --git a/nx-dev/ui-markdoc/src/lib/nodes/heading.schema.spec.ts b/nx-dev/ui-markdoc/src/lib/nodes/heading.schema.spec.ts
@@ -0,0 +1,10 @@
+import { generateID } from './heading.schema';
+
+describe('heading schema: generateID', () => {
+  it('should create ID with ony ASCII characters', () => {
+    expect(generateID(['Hello', 'World'], {})).toEqual('hello-world');
+    expect(generateID(['🎉 Pro: Simple Setup'], {})).toEqual(
+      'pro-simple-setup'
+    );
+  });
+});
diff --git a/nx-dev/ui-markdoc/src/lib/nodes/heading.schema.ts b/nx-dev/ui-markdoc/src/lib/nodes/heading.schema.ts
@@ -1,6 +1,6 @@
 import { RenderableTreeNode, Schema, Tag } from '@markdoc/markdoc';
 
-function generateID(
+export function generateID(
   children: RenderableTreeNode[],
   attributes: Record<string, any>
 ) {
@@ -10,9 +10,12 @@ function generateID(
   return children
     .filter((child) => typeof child === 'string')
     .join(' ')
-    .replace(/[?]/g, '')
-    .replace(/\s+/g, '-')
-    .toLowerCase();
+    .normalize('NFD')
+    .replace(/[\u0300-\u036f]/g, '')
+    .toLowerCase()
+    .replace(/[^a-z0-9 ]/g, '')
+    .trim()
+    .replace(/\s+/g, '-');
 }
 
 export const heading: Schema = {