Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): hide warnings when reading workspace due to extra properties #11143

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Jul 14, 2022

See before and after:
image

Fixes #11138

@vercel
Copy link

vercel bot commented Jul 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Aug 4, 2022 at 9:23PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 2dc51d7 into nrwl:master Aug 4, 2022
rlindgren pushed a commit to rlindgren/nx that referenced this pull request Aug 11, 2022
…rties (nrwl#11143)

* fix(angular): hide warnings when reading workspace due to extra properties

* fix(angular): bump angular to 14.1.1
@lztetreault-dev
Copy link

This appears to still be an issue, I'm seeing this on 14.2.5
image

@AgentEnder
Copy link
Member Author

This PR was first released in 14.5.3, so it makes sense that you'd still be seeing the behavior on 14.5.3.

That being said, in your case this is most likely a valid warning of a misconfiguration. Upon updating, you'd get a more clear picture of where exactly the problem is, but from the messages you have 2 projects that have stylePreprocessOptions and 1 with e2e as a root property in the project configuration (e.g. project.json or inside angular.json).

This is invalid, since those properties are not meant to be at the project root. The warning is indicative of this, to help you identify accidental props.

@lztetreault-dev
Copy link

@AgentEnder, thanks for the info, I'll look into that.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Angular application produces many warning "Project extension with invalid name found"
3 participants