-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix custom workspace-generator options #12821
fix(core): fix custom workspace-generator options #12821
Conversation
After PR 12258 the custom options for local workspace-generators did not work anymore because if any options are defined in the schema it added (options) to the command and if no properties were defined it also throwed an error ISSUES CLOSED: 12677
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
improve fix by using null coalescing operator after recieving feedback
…pace-generator-options
…r schema.properties
After #12955 most issues with the workspace-generators were resolved, but this PR is still resolving an existing issue when no properties object is defined in the schema.json of the generator. Can i have a review for this small changes as it is open now for almost two weeks? |
Since #12955 included most of the fix, can this PR be updated to only add the null safety? |
…pace-generator-options
revert prop.default which was accidently removed after previous fix
PR is updated to only add the null safety, because if prettier the change looks bigger than it actually is :) |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
After PR #12258 the custom options for local workspace-generators did not work anymore because if any
options are defined in the schema it added (options) to the command and if no properties were
defined it also throwed an error
ISSUES CLOSED: #12677
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #