Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support decorators in local executor and generator runs #15025

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

wSedlacek
Copy link
Contributor

Current Behavior

In 15.7 local generators and exeuctors with decorators broke, they had worked in prior versions.

Expected Behavior

Local generators and executors should allow TypeScript decorators.

@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 15, 2023 at 6:05PM (UTC)

@wSedlacek wSedlacek marked this pull request as draft February 15, 2023 18:04
@wSedlacek
Copy link
Contributor Author

wSedlacek commented Feb 15, 2023

There appears to be a bug in @swc-node/register too.
Using the latest version does not work with this change (results in the current behavior)
But using 1.5.4 and lower works with this change without issue.

Maybe this issue is related?
swc-project/swc-node#687

@AgentEnder
Copy link
Member

Hey @wSedlacek! I was about to make a similar change myself. I'm sorry to hear that its still not working, if its on the swc-node side you can always remove swc-node to fallback to ts-node which should work after this change.

@wSedlacek
Copy link
Contributor Author

My work around for now is just to lock to @swc-node/register@1.5.4 with a patch for these changes.
That works how my team needs for now.

@AgentEnder AgentEnder changed the title fix(nx): support decorators in executors and generators fix(core): support decorators in local executor and generator runs Feb 15, 2023
@AgentEnder AgentEnder merged commit f479de7 into nrwl:master Feb 15, 2023
@wSedlacek wSedlacek deleted the hotfix/decorators-in-exeuctors branch February 15, 2023 18:54
FrozenPandaz pushed a commit that referenced this pull request Feb 16, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants