Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): allow removing projects in standalone apps #16093

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

error trying to remove e2e project in standalone app

 >  NX   Could not remove e2e from projects in /jest.config.ts. Please remove e2e from your projects.


Error: Could not remove e2e from projects in /jest.config.ts. Please remove e2e from your projects.
    at updateJestConfig (/Users/caleb/Work/sandbox/node-app/node_modules/@nrwl/workspace/src/generators/remove/lib/update-jest-config.js:49:11)
    at /Users/caleb/Work/sandbox/node-app/node_modules/@nrwl/workspace/src/generators/remove/remove.js:19:51
    at Generator.next (<anonymous>)
    at fulfilled (/Users/caleb/Work/sandbox/node-app/node_modules/tslib/tslib.js:164:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Expected Behavior

remove projects in standalone app

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 1:44pm

@barbados-clemens barbados-clemens added the scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx label Apr 4, 2023
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit

@AgentEnder AgentEnder disabled auto-merge April 6, 2023 14:30
@AgentEnder AgentEnder merged commit 5afb5fc into nrwl:master Apr 6, 2023
@barbados-clemens barbados-clemens deleted the fix/jest-remove-proj branch April 6, 2023 14:34
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants