Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): update storybook to v7 #16174

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Apr 7, 2023

Update our repo to Storybook v7.

Now all the broken Storybooks are fixed!

npx nx run-many --target=build-storybook

    ✔  nx run graph-ui-components:build-storybook (28s)
    ✔  nx run graph-ui-tooltips:build-storybook (31s)
    ✔  nx run graph-ui-graph:build-storybook (36s)
    ✔  nx run graph-client:build-storybook (32s)

 ————————————————————————————————————————————————————————————————————————————————

 >  NX   Successfully ran target build-storybook for 4 projects (2m)

And the Storybook e2e tests are fixed as well:

 >  NX   Successfully ran target e2e for project e2e-storybook-angular

@vercel
Copy link

vercel bot commented Apr 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 0:58am

@mandarini mandarini self-assigned this Apr 7, 2023
Copy link
Collaborator

@philipjfulcher philipjfulcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, the storybook config is working again for graphs! 🎉 There are some issues where components are failing with an error, but I don't think they're related to the changes here. Probably more related to the Storybooks not being kept up-to-date. I will sweep through those at some point and get them working again.

@mandarini mandarini force-pushed the feat/upgrade-repo-sb7 branch 2 times, most recently from e0a88cf to df03373 Compare April 11, 2023 07:15
Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json changes look good

@mandarini mandarini merged commit c4d9a5b into nrwl:master Apr 12, 2023
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this pull request Apr 12, 2023
mandarini added a commit to mandarini/nx that referenced this pull request Apr 13, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants