Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support directory patterns for --projects #16288

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

--projects accepts project names, or tags prefixed with 'tag:'

Expected Behavior

--projects also accepts directory filters, similar to pnpm --filter

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 5:58pm

@nx-cloud
Copy link

nx-cloud bot commented Apr 13, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d68df0e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JamesHenry
Copy link
Collaborator

Nested patterns like **/* should be supported by this as well right, thanks to the matching library? Could we please add one such case to the unit tests?

// Same thing as `type:unlabeled`. If no specific type is set,
// we can waterfall through the different types until we find a match
default: {
const size = selectedProjects.size + excludedProjects.size;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment what's going on here?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants