Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repo): update storybook to v7 (#16174) #16289

Merged
merged 1 commit into from
Apr 24, 2023
Merged

feat(repo): update storybook to v7 (#16174) #16289

merged 1 commit into from
Apr 24, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Apr 13, 2023 •
edited
Loading

Reapply the update to sb7

@vercel
Copy link

vercel bot commented Apr 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 8:56pm

@mandarini mandarini self-assigned this Apr 13, 2023
@nx-cloud
Copy link

nx-cloud bot commented Apr 13, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b39df95. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@philipjfulcher philipjfulcher mentioned this pull request Apr 13, 2023
Merged
@mandarini mandarini enabled auto-merge (squash) April 18, 2023 12:23
@jaysoo jaysoo closed this Apr 18, 2023
auto-merge was automatically disabled April 18, 2023 12:57

Pull request was closed

@jaysoo jaysoo reopened this Apr 18, 2023
@mandarini mandarini enabled auto-merge (squash) April 18, 2023 13:00
meeroslav
meeroslav approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please change @nrwl/... to @nx/... since deep imports don't work in pnpm due to hoisting restrictions.

@mandarini mandarini force-pushed the feat/re-apply-sb7 branch 2 times, most recently from b0b472f to 86ba5b9 Compare April 18, 2023 14:41
@mandarini mandarini merged commit 9bb5d0d into nrwl:master Apr 24, 2023
This was referenced Apr 28, 2023
Closed
Closed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

@meeroslav meeroslav meeroslav approved these changes

@FrozenPandaz FrozenPandaz FrozenPandaz approved these changes

@Coly010 Coly010 Coly010 approved these changes

@vsavkin vsavkin Awaiting requested review from vsavkin vsavkin is a code owner

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry is a code owner

@leosvelperez leosvelperez Awaiting requested review from leosvelperez

@philipjfulcher philipjfulcher Awaiting requested review from philipjfulcher philipjfulcher is a code owner

@bcabanes bcabanes Awaiting requested review from bcabanes bcabanes is a code owner

@AgentEnder AgentEnder Awaiting requested review from AgentEnder AgentEnder is a code owner

Assignees

@mandarini mandarini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mandarini @jaysoo @meeroslav @FrozenPandaz @Coly010