Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): remove deprecated executors #16416

Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 19, 2023

This PR removes executors that we deprecated back in Nx 13 : @nrwl/web:rollup, @nrwl/web:webpack, @nrwl/web:dev-server, @nrwl/node:webpack. The migrations were applied back in Nx 14 and Nx 15, so people have had enough time to adapt.

Notes

  • Another migration is added if users skipped the last two
  • Replaced references to @nx/web:rollup with @nx/rollup:rollup (some were tests or test fixtures)

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 9:03pm

@AgentEnder
Copy link
Member

@jaysoo Can we rerun the migration that moves people to use the new executors?

Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at this line please?

It's being generated in @nx/react-native

packages/web/executors.json Show resolved Hide resolved
@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch from 3e62ca0 to 6255677 Compare April 19, 2023 18:16
@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch from 6255677 to 5ffe60f Compare April 19, 2023 18:17
@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch 2 times, most recently from dda54a9 to 965fe22 Compare April 19, 2023 18:19
@jaysoo
Copy link
Member Author

jaysoo commented Apr 19, 2023

@jaysoo Can we rerun the migration that moves people to use the new executors?

Sure, we can do it a third time. 😅

@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch from 965fe22 to 056adbf Compare April 19, 2023 18:31
@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch 2 times, most recently from e92a544 to 1b3fdc7 Compare April 19, 2023 19:46
@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch from d986171 to e8384da Compare April 19, 2023 20:54
Copy link
Collaborator

@FrozenPandaz FrozenPandaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, could you also add redirects for nx.dev?

@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch from e8384da to eca3160 Compare April 20, 2023 12:18
@jaysoo jaysoo force-pushed the feat/web-remove-deprecated-executors branch from 3300a29 to 5d16c91 Compare April 20, 2023 15:17
@FrozenPandaz FrozenPandaz merged commit 8de17ab into nrwl:master Apr 20, 2023
@jaysoo jaysoo deleted the feat/web-remove-deprecated-executors branch April 21, 2023 12:39
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants