-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): remove deprecated executors #16416
feat(web): remove deprecated executors #16416
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jaysoo Can we rerun the migration that moves people to use the new executors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take a look at this line please?
executor: '@nx/web:rollup', |
It's being generated in @nx/react-native
3e62ca0
to
6255677
Compare
6255677
to
5ffe60f
Compare
dda54a9
to
965fe22
Compare
Sure, we can do it a third time. 😅 |
965fe22
to
056adbf
Compare
e92a544
to
1b3fdc7
Compare
1b3fdc7
to
d986171
Compare
d986171
to
e8384da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, could you also add redirects for nx.dev?
e8384da
to
eca3160
Compare
eca3160
to
39087ba
Compare
39087ba
to
3300a29
Compare
3300a29
to
5d16c91
Compare
5d16c91
to
4e409bd
Compare
4e409bd
to
8cbcdb3
Compare
8cbcdb3
to
48f51ca
Compare
48f51ca
to
9dd476a
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR removes executors that we deprecated back in Nx 13 :
@nrwl/web:rollup
,@nrwl/web:webpack
,@nrwl/web:dev-server
,@nrwl/node:webpack
. The migrations were applied back in Nx 14 and Nx 15, so people have had enough time to adapt.Notes
@nx/web:rollup
with@nx/rollup:rollup
(some were tests or test fixtures)