feat(linter): rename @nx/eslint-plugin-nx to @nx/eslint-plugin #16420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenPandaz
requested review from
bcabanes,
jaysoo,
AgentEnder,
isaacplmann,
juristr,
barbados-clemens,
vsavkin,
meeroslav,
JamesHenry,
nartc,
ndcunningham,
mandarini,
xiongemi,
Coly010 and
leosvelperez
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
force-pushed
the
rescope-linter
branch
from
a03f5c5
to
431de7c
Compare
FrozenPandaz
force-pushed
the
rescope-linter
branch
from
431de7c
to
7c43180
Compare
AgentEnder
requested changes
Apr 19, 2023
barbados-clemens
approved these changes
Apr 19, 2023
FrozenPandaz
force-pushed
the
rescope-linter
branch
from
7c43180
to
5251479
Compare
FrozenPandaz
force-pushed
the
rescope-linter
branch
2 times, most recently
from
a3ccc35
to
863f642
Compare
nartc
approved these changes
Apr 20, 2023
Coly010
approved these changes
Apr 20, 2023
mandarini
approved these changes
Apr 20, 2023
JamesHenry
requested changes
Apr 20, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
FrozenPandaz
force-pushed
the
rescope-linter
branch
from
863f642
to
6af5e2e
Compare
meeroslav
reviewed
Apr 20, 2023
meeroslav
reviewed
Apr 20, 2023
| "root": "/packages/eslint-plugin-nx", | ||
| "source": "/packages/eslint-plugin-nx/src" | ||
| "name": "eslint-plugin", | ||
| "packageName": "@nrwl/eslint-plugin", |
There was a problem hiding this comment.
This is invalid - should be @nrwl/eslint-plugin-nx
meeroslav
reviewed
Apr 20, 2023
| @@ -32,6 +32,5 @@ | |||
| ] | |||
| } | |||
| } | |||
| }, | |||
| "implicitDependencies": ["eslint-plugin-nx"] | |||
There was a problem hiding this comment.
Why was this removed?
If you remove this, then e2e-linter project needs implicit dependency of eslint-plugin-nx
There was a problem hiding this comment.
This is the legacy package, it only has a dependency on @nx/linter
meeroslav
requested changes
Apr 20, 2023
FrozenPandaz
force-pushed
the
rescope-linter
branch
from
6af5e2e
to
dffa7ca
Compare
meeroslav
approved these changes
Apr 20, 2023
jaysoo
approved these changes
Apr 20, 2023
AgentEnder
approved these changes
Apr 20, 2023
| @@ -5,7 +5,7 @@ export default { | |||
| }, | |||
| moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'html'], | |||
| globals: {}, | |||
| displayName: 'eslint-plugin-nx', | |||
| displayName: 'packages-eslint-plugin', | |||
There was a problem hiding this comment.
non-blocking: Does this need the packages- prefix? We don't use that elsewhere for this
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The new
@nx/eslint-plugin-nxpackage means the rules look like@nx/nx/enforce-module-boundarieswhich is redundant.Expected Behavior
The new
@nx/eslint-plugin-nxpackage is now@nx/eslint-pluginmeans the rules look like@nx/enforce-module-boundarieswhich is better.Related Issue(s)
Fixes #