Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): safely iterate over package.json scripts in nx init command #16508

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 24, 2023

Current Behavior

Running nx init command on a repo where the package.json file doesn't have a scripts entry throws an error.

Expected Behavior

The nx init command should safely handle a repo with a package.json without a scripts entry.

Related Issue(s)

Fixes #16505

@leosvelperez leosvelperez self-assigned this Apr 24, 2023
@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 3:45pm

@AgentEnder AgentEnder merged commit dffb3d3 into nrwl:master Apr 24, 2023
@leosvelperez leosvelperez deleted the misc/nx-init-null-safe-objects branch April 25, 2023 07:25
@github-actions
Copy link

github-actions bot commented May 1, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot convert undefined or null to object on init
2 participants