fix(core): use nx@next when migrating to next
#16557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
fix/use-next-for-migrate-when-migrating-to-next
branch
from
8de78e5
to
2badf11
Compare
FrozenPandaz
requested changes
Apr 26, 2023
Comment on lines
1026
to
1028
| function nxCliPath( | ||
| version = process.env.NX_MIGRATE_USE_NEXT === 'true' ? 'next' : 'latest' | ||
| ) { |
There was a problem hiding this comment.
This is a weird function name, can we change it to like... installNxTemporarily(version: 'latest' | 'next')?
Don't make it optional, and move the environment variable check outside of here.
AgentEnder
force-pushed
the
fix/use-next-for-migrate-when-migrating-to-next
branch
from
2badf11
to
1268a9c
Compare
FrozenPandaz
approved these changes
Apr 26, 2023
AgentEnder
force-pushed
the
fix/use-next-for-migrate-when-migrating-to-next
branch
from
1268a9c
to
0f5f997
Compare
This was referenced Apr 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #