Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): ensure that bundlers for node is webpack/esbuild #16702

Merged
merged 1 commit into from
May 2, 2023
Merged

fix(node): ensure that bundlers for node is webpack/esbuild #16702

merged 1 commit into from
May 2, 2023

Conversation

ndcunningham
Copy link
Contributor

closed #16686

@vercel
Copy link

vercel bot commented May 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 4:29pm

@ndcunningham ndcunningham self-assigned this May 2, 2023
@ndcunningham ndcunningham added scope: node Issues related to Node, Express, NestJS support for Nx scope: bundlers Issues related to webpack, rollup labels May 2, 2023
@nx-cloud
Copy link

nx-cloud bot commented May 2, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3659733. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@ognjenjevremovic ognjenjevremovic mentioned this pull request May 2, 2023
Closed
@jaysoo jaysoo merged commit 8dec11e into nrwl:master May 2, 2023
@ndcunningham ndcunningham deleted the fix/node-bundler-default branch May 2, 2023 17:55
FrozenPandaz pushed a commit that referenced this pull request May 2, 2023
@ndcunningham @FrozenPandaz
fix(node): ensure that bundlers for node is webpack/esbuild (#16702)
7f060ae 
(cherry picked from commit 8dec11e)
@timonmasberg timonmasberg mentioned this pull request May 3, 2023
Closed
@github-actions github-actions bot mentioned this pull request May 3, 2023
Closed
AgentEnder pushed a commit to AgentEnder/nx that referenced this pull request May 3, 2023
@ndcunningham @AgentEnder
fix(node): ensure that bundlers for node is webpack/esbuild (nrwl#16702)
b7ecd81
FrozenPandaz pushed a commit that referenced this pull request May 3, 2023
@AgentEnder
fix(misc): sort plugin names when displaying them (#16702) (#16734)
2d6ea2b
@timonmasberg timonmasberg mentioned this pull request May 5, 2023
Closed
@github-actions github-actions bot mentioned this pull request May 5, 2023
Closed
@github-actions
Copy link

github-actions bot commented May 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaysoo jaysoo jaysoo approved these changes

@AgentEnder AgentEnder AgentEnder approved these changes

@FrozenPandaz FrozenPandaz Awaiting requested review from FrozenPandaz

@vsavkin vsavkin Awaiting requested review from vsavkin

@nartc nartc Awaiting requested review from nartc

Assignees

@ndcunningham ndcunningham

Labels
scope: bundlers Issues related to webpack, rollup scope: node Issues related to Node, Express, NestJS support for Nx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to resolve @nx/webpack:webpack Error on newly created NX repository, when invoking npm run start
3 participants
@ndcunningham @jaysoo @AgentEnder