Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): apply target defaults properly for executors defaults #18655

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

@FrozenPandaz FrozenPandaz commented Aug 16, 2023

Current Behavior

Target defaults setup like the following are not applied:


  "targetDefaults": {
    "@nx/jest:jest": {
      "inputs": ["default", "^production", "{workspaceRoot}/jest.preset.js"],
      "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
      "options": {
        "jestConfig": "{projectRoot}/jest.config.ts",
        "passWithNoTests": true
      }
    },

Expected Behavior

Target defaults like the above are applied

Related Issue(s)

Fixes #18650

@FrozenPandaz FrozenPandaz requested a review from a team as a code owner August 16, 2023 15:42
@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2023 3:48pm

@AgentEnder AgentEnder merged commit f670e74 into nrwl:master Aug 16, 2023
3 checks passed
FrozenPandaz added a commit that referenced this pull request Aug 16, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

targetDefaults not merged into project descriptions since NX 16.7.0
2 participants