Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petition - re-open #11922 (support marking a subset of packages as 'affected' due to root level file change) #19292

Closed
4 tasks
Druotic opened this issue Sep 22, 2023 · 8 comments
Labels

Comments

@Druotic
Copy link

Druotic commented Sep 22, 2023

Current Behavior

See: Changing a file referenced by a namedInput using {workspaceRoot} affects all packages #11922

This is an ongoing issue. Wanting to mark e.g. 3 out of 10 packages as 'affected' when a root level file changes seems like a fairly typical behavior. This functionality was previously supported here pre-v14.4. The new namedInputs equivalent seems to be all-or-nothing. See original ticket.

Let me know if there's a better way to '+1' the issue to help gauge interest. Because the original issue has been closed, I am unable to +1 the issue. I suspect there are other people out there that would have otherwise +1'd the issue, but moved on to another solution instead.

Expected Behavior

n/a

GitHub Repo

No response

Steps to Reproduce

n/a

Nx Report

n/a

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@Druotic Druotic changed the title Petition - re-open #11922 Petition - re-open #11922 (support marking a subset of packages as 'affected') Sep 22, 2023
@Druotic Druotic changed the title Petition - re-open #11922 (support marking a subset of packages as 'affected') Petition - re-open #11922 (support marking a subset of packages as 'affected' due to root level file change) Sep 22, 2023
@AgentEnder AgentEnder added the scope: core core nx functionality label Sep 22, 2023
@zackarydev
Copy link

+1 We are having big issues with rebuilding the entire code base whenever a root file change occurs (Ex: a README should not rebuild all apps!)
#19277

@khalilou88
Copy link
Contributor

Following this issue because i have similar issue here : khalilou88/jnxplus#423

@xeinebiu
Copy link

#19000 (comment)

@mpsanchis
Copy link
Contributor

I'm also interested. Using https://github.com/khalilou88/jnxplus at the moment, and trying to trigger only the necessary modules

Copy link

This issue has been automatically marked as stale because it hasn't had any recent activity. It will be closed in 14 days if no further activity occurs.
If we missed this issue please reply to keep it active.
Thanks for being a part of the Nx community! 🙏

@github-actions github-actions bot added the stale label Mar 27, 2024
@Druotic
Copy link
Author

Druotic commented Mar 27, 2024

I'm surprised this hasn't seen any activity lately. Is there a newer workaround for this? It still seems to be an issue.

@github-actions github-actions bot removed the stale label Mar 28, 2024
@FrozenPandaz
Copy link
Collaborator

This was fixed with #22573. 🎉

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants