Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since upgrading nx from 17.2.8 to 18.0.4 my ui projects are suddenly unable to build #21978

Closed
4 tasks
brandoncollins7 opened this issue Feb 23, 2024 · 6 comments · Fixed by #22294
Closed
4 tasks
Labels
outdated scope: react Issues related to React support for Nx type: bug

Comments

@brandoncollins7
Copy link

brandoncollins7 commented Feb 23, 2024

Current Behavior

seems to be a wierd issue my svg's. I can't understand why upgrading nx would cause this issue:

ERROR in ./src/components/SeidoLogo/seido-logo.svg
Module build failed (from ../../../node_modules/.pnpm/@svgr+webpack@8.0.1/node_modules/@svgr/webpack/dist/index.js):
TypeError: Cannot read properties of null (reading 'tagName')
at Object.parse (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm\svg-parser@2.0.4\node_modules\svg-parser\dist\svg-parser.umd.js:279:15)
at jsxPlugin (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+plugin-jsx@8.0.1_@svgr+core@8.0.0\node_modules@svgr\plugin-jsx\dist\index.js:57:30)
at run (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+core@8.0.0\node_modules@svgr\core\dist\index.js:174:16)
at Object.transform (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+core@8.0.0\node_modules@svgr\core\dist\index.js:180:10)
at async C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+webpack@8.0.1\node_modules@svgr\webpack\dist\index.js:66:20

ERROR in ../../../libs/ui/base-ui/src/lib/components/icons/crypto-icon/cad.color.svg
Module build failed (from ../../../node_modules/.pnpm/@svgr+webpack@8.0.1/node_modules/@svgr/webpack/dist/index.js):
TypeError: Cannot read properties of null (reading 'tagName')
at Object.parse (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm\svg-parser@2.0.4\node_modules\svg-parser\dist\svg-parser.umd.js:279:15)
at jsxPlugin (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+plugin-jsx@8.0.1_@svgr+core@8.0.0\node_modules@svgr\plugin-jsx\dist\index.js:57:30)
at run (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+core@8.0.0\node_modules@svgr\core\dist\index.js:174:16)
at Object.transform (C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+core@8.0.0\node_modules@svgr\core\dist\index.js:180:10)
at async C:\Users\brand\Documents\Projects\atlantic-dawn-monorepo\node_modules.pnpm@svgr+webpack@8.0.1\node_modules@svgr\webpack\dist\index.js:66:20

Expected Behavior

should build the same as before

GitHub Repo

No response

Steps to Reproduce

Nx Report

Node   : 18.17.0
   OS     : win32-x64
   pnpm   : 7.32.0

   nx                 : 18.0.4
   @nx/js             : 18.0.4
   @nx/jest           : 18.0.4
   @nx/linter         : 18.0.4
   @nx/eslint         : 18.0.4
   @nx/workspace      : 18.0.4
   @nx/cypress        : 18.0.4
   @nx/devkit         : 18.0.4
   @nx/esbuild        : 18.0.4
   @nx/eslint-plugin  : 18.0.4
   @nx/nest           : 18.0.4
   @nx/next           : 18.0.4
   @nx/node           : 18.0.4
   @nx/react          : 18.0.4
   @nx/storybook      : 18.0.4
   @nrwl/tao          : 18.0.4
   @nx/vite           : 18.0.4
   @nx/web            : 18.0.4
   @nx/webpack        : 18.0.4
   typescript         : 5.1.6
   ---------------------------------------
   Community plugins:
   @nx-tools/nx-container : 5.0.2
   @nx-tools/nx-prisma    : 5.0.2

Failure Logs

No response

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@AgentEnder AgentEnder added the scope: react Issues related to React support for Nx label Feb 24, 2024
@mklueh
Copy link

mklueh commented Feb 26, 2024

I'm facing a similar issue with @nx/vite. Builds are failing with

NX The "path" argument must be of type string. Received undefined

@remcogerlich
Copy link

I have this with @nx/webpack. Seems similar to #14383 , but that was fixed.

@mattcat10
Copy link

I have this with @nx/webpack. Seems similar to #14383 , but that was fixed.

Also seeing this issue with @nx/webpack": "18.0.8"

@dotrakoun-clearstreet
Copy link

also see it with nx next, using svgs from a lib in my next app

@airowe
Copy link

airowe commented Mar 13, 2024

Getting this as well. Any solutions?

Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: react Issues related to React support for Nx type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants