-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to combine Expo and React applications in the same workspace #26118
Comments
+1 i also encountered this |
Even the android build within the expo app fails. Fails with this error: #Ticket for the above |
i think you can remove the webpack.config.js in the expo app, and then |
@xiongemi thanks for quick response. Yes, my issue has workaround as described 🙂 |
config.js <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26118 #25291 #23233
config.js <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #26118 #25291 #23233 (cherry picked from commit 2cb7ecb)
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
Workspace with only Expo application works fine but after React app is generated, neither Expo nor React apps can be launched due to project graph error.
Expected Behavior
Both Expo and React apps launched successfully
GitHub Repo
https://github.com/vaagnavanesyan/nx-expo-react-repro
Steps to Reproduce
yarn create nx-workspace expo-and-react
with following answers:nx add @nx/expo
yarn nx generate @nx/expo:application --name=my-expo-app --directory=apps/my-expo-app --e2eTestRunner=none --projectNameAndRootFormat=as-provided --no-interactive
nx start my-expo-app
nx add @nx/react
yarn nx generate @nx/react:application --name=my-react-app --directory=apps/my-react-app --e2eTestRunner=none --projectNameAndRootFormat=as-provided --no-interactive
nx start my-expo-app
Attached repo contains commits for each step to make it more easy to reproduce
Nx Report
Failure Logs
Package Manager Version
yarn@1.22.22
Operating System
Additional Information
WORKAROUND
apps/my-expo-app/webpack.config.js
nx start my-expo-app
POSSIBLE REASON
@nx/expo:application
generator usesmetro
as bundler for web. Seeapp.json
template. But at the same time the generator createswebpack.config.js
with deprecation warning. It's unclear for me why do we need that config if we don't use Webpack, or we use it? 🤔The text was updated successfully, but these errors were encountered: