Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should workspace-data be .gitignored? #26519

Closed
2 tasks done
csi-lk opened this issue Jun 12, 2024 · 3 comments · Fixed by #26520
Closed
2 tasks done

Should workspace-data be .gitignored? #26519

csi-lk opened this issue Jun 12, 2024 · 3 comments · Fixed by #26520
Assignees
@isaacplmann
Labels
outdated scope: docs Issues related to generic docs type: docs

Comments

@csi-lk
Copy link
Contributor

csi-lk commented Jun 12, 2024 •
edited
Loading

After updating to latest we now have a workspace-data folder being created for nx during installation

Should this folder be .gitignored?

The docs only mention .nx/cache but it seems you have added it to the ignore in the repo and the generator

Documentation issue

  • Reporting a documentation bug
  • Documentation improvement
csi-lk added a commit to csi-lk/nx that referenced this issue Jun 12, 2024
@csi-lk
docs: add .nx/workspace-data to .gitignore in manual setup
cb9d129 
folder is created during install but is not required to be committed

resolves nrwl#26519
@csi-lk csi-lk mentioned this issue Jun 12, 2024
Merged
@csi-lk
Copy link
Contributor Author

csi-lk commented Jun 12, 2024

Opened a PR #26520 to change the docs if the answer is "yes this should be ignored"

@FrozenPandaz FrozenPandaz added the scope: docs Issues related to generic docs label Jun 13, 2024
@crusoexia
Copy link

Curious with this too.

FrozenPandaz pushed a commit that referenced this issue Jun 21, 2024
@csi-lk @FrozenPandaz
docs(misc): add .nx/workspace-data to .gitignore in manual setup (#…
42fc597 
…26520)

folder is created during install but is not required to be committed

feel free to close if not required

resolves #26519

---------

Co-authored-by: Isaac Mann <isaacplmann@gmail.com>
(cherry picked from commit df2ff2d)
@github-actions GitHub Actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isaacplmann isaacplmann

Labels
outdated scope: docs Issues related to generic docs type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(misc): add .nx/workspace-data to .gitignore in manual setup csi-lk/nx
4 participants
@isaacplmann @csi-lk @crusoexia @FrozenPandaz