Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics/workspace): should use git mv to move src to apps/ #32

Closed
jeffbcross opened this issue Oct 3, 2017 · 3 comments
Closed

Comments

@jeffbcross
Copy link
Member

Right now, the upgrade process just moves the folder, which doesn't preserve git history of moved files correctly.

Ideally, if the project is a git repo, and git is installed, the src directory should be moved using git mv, and a commit should be immediately created for the move and the other files changed/created by the conversion. By creating a commit immediately after git mv, then the git history will have a minimal commit showing the existing files being renamed (and will reduce risk that git will not recognize it as a rename due to other changes to existing files being applied in the same revision).

@bcabanes
Copy link
Member

bcabanes commented Nov 1, 2019

The ng add command already preserve the history. We could add another command that will be an import process. E.g: nx import apps.

@vsavkin vsavkin closed this as completed Dec 4, 2019
@vsavkin
Copy link
Member

vsavkin commented Dec 4, 2019

Going to open another issue for nx import

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants