Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish new files with an empty line #72

Closed
mgol opened this issue Oct 24, 2017 · 3 comments
Closed

Finish new files with an empty line #72

mgol opened this issue Oct 24, 2017 · 3 comments
Assignees

Comments

@mgol
Copy link

mgol commented Oct 24, 2017

After converting a CLI app into an nx one via https://nrwl.io/nx/guide-nx-workspace#convert-an-angularcli-project-to-an-nx-workspace my package.json & .angular-cli.json are missing empty lines at their ends. Many editors add such an empty line automatically as it reduces noise in Git diffs (otherwise adding a line at the end creates a difference in two lines as a line break is counted into the preceding line).

Most tools like npm or Yarn generate JSON files with a trailing new line as well so it'd be good to align.

@mgol
Copy link
Author

mgol commented Oct 24, 2017

(checked with CLI 1.5.0-rc.3 & @nrwl/schematics 0.0.7)

@vsavkin
Copy link
Member

vsavkin commented Oct 31, 2017

Fixed here c09ba79

@vsavkin vsavkin closed this as completed Oct 31, 2017
FrozenPandaz added a commit to FrozenPandaz/nx that referenced this issue Jan 12, 2023
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants