Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): change-storybook-targets should not fail if no build #11038

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

mandarini
Copy link
Member

Current Behavior

change-storybook-targets generator (and migrator - they are the same) throws an error if there is no target configured for building Storybook.

Expected Behavior

change-storybook-targets generator (and migrator - they are the same) should work even if there is no target set for building Storybook.

@mandarini mandarini self-assigned this Jul 6, 2022
@vercel
Copy link

vercel bot commented Jul 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jul 6, 2022 at 1:08PM (UTC)

@mandarini mandarini requested a review from meeroslav July 6, 2022 13:08
@mandarini mandarini enabled auto-merge (squash) July 6, 2022 13:11
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment. Otherwise looks good to me! Thank you!

@mandarini mandarini merged commit 01e25ec into nrwl:master Jul 6, 2022
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants