Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(angular): add @angular-eslint/builder:lint builder migrator #13151

Merged

Conversation

leosvelperez
Copy link
Member

Current Behavior

The Angular CLI migrator generator is split per project migrators which contain all the logic to do the migration in them.

Expected Behavior

The @angular-eslint/builder:lint builder now has its own dedicated migrator, and its associated logic was removed from the application and library migrators.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 14, 2022
@vercel
Copy link

vercel bot commented Nov 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Nov 14, 2022 at 1:27PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leosvelperez leosvelperez merged commit 2a671e7 into nrwl:master Nov 14, 2022
@leosvelperez leosvelperez deleted the angular/add-eslint-builder-migrator branch November 14, 2022 13:52
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants