Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devkit): adjust behavior of the "addDependenciesToPackageJson" function #14682

Merged

Conversation

dmitry-stepanenko
Copy link
Contributor

Current Behavior

  1. Right now addDependenciesToPackageJson will fail if in package.json there're packages with not semantic version (e.g. git://github.com/npm/cli.git#v1.0.27 or github:builderio/qwik-build
  2. Packages with lower version than specified in package.json may get installed if provided dependencies are all of the same type (dependencies or devDependencies). This was a bit weird, but is perfectly demonstrated with unit tests added in the second commit

Expected Behavior

Issues above should not exist

@vercel
Copy link

vercel bot commented Jan 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 8:37AM (UTC)

@FrozenPandaz
Copy link
Collaborator

Thank you for your contribution! LGTM 🎉

@FrozenPandaz FrozenPandaz merged commit 544e8d5 into nrwl:master Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants