Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use smarter nesting of npm packages #15502

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Nesting of the packages in npm stringification is done prematurely, occasionally leading to overrides of nested packages.

Expected Behavior

The nesting should be done pessimistically at first with another run to check if better (higher up the dependency tree) nesting is possible for the given package.

Related Issue(s)

Fixes #15366

@meeroslav meeroslav self-assigned this Mar 7, 2023
@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 2:34PM (UTC)

@FrozenPandaz FrozenPandaz merged commit 8d3f2bd into nrwl:master Mar 7, 2023
FrozenPandaz pushed a commit that referenced this pull request Mar 8, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
@meeroslav meeroslav deleted the fix-npm-package-nesting branch April 27, 2023 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: core core nx functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lockfile generation still is buggy with 15.8.1
2 participants