Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): undo core-js removal #17048

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented May 16, 2023

We need to check if it is still needed in polyfills before removing. Let's keep it for now since users probably wouldn't remove polyfillts.ts themselves, so likely will need core-js for older projects.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2023 0:14am

@jaysoo jaysoo merged commit 826befa into nrwl:master May 16, 2023
@jaysoo jaysoo deleted the fix/undo-core-js-removal branch May 16, 2023 13:32
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants