feat(misc): change updateBuildableProjectDepsInPackageJson option default value to false #17920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 63faf43. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
misc/toggle-flag-default-value
branch
from
78ca70a
to
dde4266
Compare
leosvelperez
force-pushed
the
misc/toggle-flag-default-value
branch
from
dde4266
to
0625c19
Compare
leosvelperez
force-pushed
the
misc/toggle-flag-default-value
branch
from
0625c19
to
90a0b4e
Compare
isaacplmann
approved these changes
Jul 5, 2023
…ault value to false
leosvelperez
force-pushed
the
misc/toggle-flag-default-value
branch
from
90a0b4e
to
63faf43
Compare
jaysoo
reviewed
Jul 5, 2023
packages/js/src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps.ts
Show resolved
Hide resolved
jaysoo
reviewed
Jul 5, 2023
packages/js/src/migrations/update-16-6-0/explicitly-set-projects-to-update-buildable-deps.ts
Show resolved
Hide resolved
jaysoo
approved these changes
Jul 5, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to moving from using the current package.json generation in executors to using the new
@nx/dependency-checksEsLint rule instead. In a follow-up PR, the options will be deprecated.The PR comes with migrations for targets using the relevant executors and are relying on the default value for the
updateBuildableProjectDepsInPackageJson. In those cases, the option will be explicitly set totruein the target configuration to keep the existing behavior.Current Behavior
The
updateBuildableProjectDepsInPackageJsonoption of several executors has a default value oftrue.Expected Behavior
The
updateBuildableProjectDepsInPackageJsonoption of several executors should have a default value offalse.Related Issue(s)
Fixes #