feat(core): add WorkspaceContext class #18999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Cammisuli
force-pushed
the
feature/nxc-2-nx-workspace-context-class
branch
5 times, most recently
from
20f147b
to
c1bee5b
Compare
Cammisuli
requested review from
meeroslav,
vsavkin,
mandarini,
a team and
FrozenPandaz
as code owners
Cammisuli
force-pushed
the
feature/nxc-2-nx-workspace-context-class
branch
2 times, most recently
from
79fb42e
to
9b7fc60
Compare
mandarini
approved these changes
Sep 12, 2023
FrozenPandaz
requested changes
Sep 12, 2023
packages/nx/src/daemon/server/project-graph-incremental-recomputation.ts
Outdated
Show resolved
Hide resolved
Cammisuli
force-pushed
the
feature/nxc-2-nx-workspace-context-class
branch
from
9b7fc60
to
5a5e012
Compare
FrozenPandaz
approved these changes
Sep 13, 2023
| @@ -437,6 +435,14 @@ class TaskHasherImpl { | |||
| return partialHashes; | |||
| } | |||
|
|
|||
| private hashFiles(files: string[]): Map<string, string> { | |||
There was a problem hiding this comment.
Let's rename this to hashOutputFile in a followup PR so that people are less likely to use this for getting hashes of workspace files.
|
Nice job :) This is awesome! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There are certain points of the nx project graph life cycle where we keep trying to walk the directory to get information. Particularly for project configurations and file hashes.
Expected Behavior
There is now one central point where the file system (with respecting .gitignores and .nxignore) is stored in memory. This allows following calls to hit the memory file system, rather than have to traverse the system each time.
Related Issue(s)
Fixes #