Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): switch default to typescript configuration for module federation #19031

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Sep 6, 2023

Current Behavior

We currently generate JS config files for webpack and module federation with the host and remote generators

Expected Behavior

We should generate TS config Files

Related Issue(s)

Fixes #

Notes

BLOCKED BY #18996

@Coly010 Coly010 self-assigned this Sep 6, 2023
@Coly010 Coly010 requested a review from jaysoo September 6, 2023 15:42
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 1:13pm

@Coly010 Coly010 merged commit 11fcb8f into nrwl:master Sep 18, 2023
3 checks passed
@Coly010 Coly010 deleted the mf/use-ts-configuration-react branch September 18, 2023 17:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants