-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): switch default to typescript configuration for module federation #19031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
mf/use-ts-configuration-react
branch
from
September 18, 2023 09:59
1106a7d
to
c9a999a
Compare
Coly010
force-pushed
the
mf/use-ts-configuration-react
branch
from
September 18, 2023 12:15
c9a999a
to
fb8b956
Compare
Coly010
force-pushed
the
mf/use-ts-configuration-react
branch
from
September 18, 2023 13:08
fb8b956
to
aaccb57
Compare
jaysoo
approved these changes
Sep 18, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently generate JS config files for webpack and module federation with the host and remote generators
Expected Behavior
We should generate TS config Files
Related Issue(s)
Fixes #
Notes
BLOCKED BY #18996