Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): update the native runtime input to include the cpu architecture #19263

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Sep 20, 2023

Current Behavior

We currently have a runtime input for native builds that include the platform only. This case fails if trying to run on darwin x64, when a cache artifact was uploaded with darwin arm.

Expected Behavior

The runtime input now includes the cpu architecture to make sure arm and x64 machines don't get the wrong cache.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 20, 2023 6:34pm

@FrozenPandaz FrozenPandaz merged commit 42202cb into nrwl:master Sep 20, 2023
1 of 2 checks passed
@Cammisuli Cammisuli deleted the update_native_runtime_input branch September 20, 2023 19:16
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants